Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goplus debug support #49

Merged
merged 30 commits into from
Feb 7, 2024
Merged

goplus debug support #49

merged 30 commits into from
Feb 7, 2024

Conversation

tsingbx
Copy link

@tsingbx tsingbx commented Jan 1, 2024

No description provided.

);
throw new Error('Cannot find Delve debugger (dlv dap)');
throw new Error('Cannot find Gop/go debugger (gopdlv dap)');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gop/go => Go/Go+

@@ -442,7 +442,7 @@ export class DelveDAPOutputAdapter extends ProxyDebugAdapter {
command: 'runInTerminal',
arguments: {
kind: console,
title: `Go Debug Terminal (${launchAttachArgs.name})`,
title: `Gop Debug Terminal (${launchAttachArgs.name})`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gop => Go+

}
} catch (e) {
logError(`The program "${program}" does not exist: ${e}`);
return reject('The program attribute must point to valid directory, .go file or executable.');
return reject(`The program "${program}" does not exist: ${e}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reject message is changed.

env['GOPATH'] ? ', ' + env['GOPATH'] : ''
} or ${getEnvPath()}`
);
return reject(
'Cannot find Delve debugger. Install from https://github.com/go-delve/delve & ensure it is in your Go tools path, "GOPATH/bin" or "PATH".'
'Cannot find Gop/go debugger. Install from https://github.com/goplus/gopdlv & ensure it is in your Go tools path, "GOPATH/bin" or "PATH".'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gop/go => Go/Go+

@@ -667,7 +668,7 @@ export class Delve {

if (!existsSync(launchArgs.dlvToolPath)) {
return reject(
'Cannot find Delve debugger. Install from https://github.com/go-delve/delve & ensure it is in your Go tools path, "GOPATH/bin" or "PATH".'
'Cannot find Gop/go debugger. Install from https://github.com/goplus/gopdlv & ensure it is in your Go tools path, "GOPATH/bin" or "PATH".'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as same

@@ -68,22 +68,22 @@ export class GoDebugConfigurationProvider implements vscode.DebugConfigurationPr
}
},
{
label: 'Go: Attach to local process',
label: 'Gop: Attach to local process',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gop => Go+

request: 'attach',
mode: 'local',
processId: 0
}
},
{
label: 'Go: Connect to server',
label: 'Gop: Connect to server',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as same

@@ -18,17 +18,17 @@ import { getWorkspaceFolderPath } from './util';
import { getEnvPath, getBinPathFromEnvVar } from './utils/pathUtils';

export function activate(ctx: vscode.ExtensionContext) {
const debugOutputChannel = vscode.window.createOutputChannel('Go Debug');
const debugOutputChannel = vscode.window.createOutputChannel('Gop Debug');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gop => Go+

if (!editor.document.fileName.endsWith('.go')) {
vscode.window.showInformationMessage('Current file is not a Go file.');
if (!(editor.document.fileName.endsWith('.go') || editor.document.fileName.endsWith('.gop'))) {
vscode.window.showInformationMessage('Current file is not a Go or Gop file.');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go or Gop => Go/Go+

@@ -54,12 +54,12 @@ export const toggleTestFile: CommandFactory = () => () => {
}
const currentFilePath = editor.document.fileName;
if (!currentFilePath.endsWith('.go') && !currentFilePath.endsWith('.gop')) {
vscode.window.showInformationMessage('Cannot toggle test file. File in the editor is not a Go file.');
vscode.window.showInformationMessage('Cannot toggle test file. File in the editor is not a Go or Gop file.');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as same

Copy link

qiniu-x bot commented Feb 7, 2024

[Git-flow] Hi @tsingbx, There are some suggestions for your information:


Rebase suggestions

  • Following commits seems generated via git merge

    Merge branch 'debug' of https://github.com/tsingbx/vscode-gop into debug

  • Following commits have duplicated messages

    undo skip test

    undo skip test

    change version

    change version

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here:

@xushiwei xushiwei merged commit 4125980 into goplus:goplus Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants